Fix Particle errors #81 #82
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Treer
force-pushed
the
feature/fix-particle-errors
branch
2 times, most recently
from
a42b95d to
685761b
Compare
|
|
Somewhere between minetest v5.8 and 5.9, it stopped allowing texture modifiers without a baseimg ERROR[Main]: generateImage(): baseimg is NULL (attempted to create texture "") ERROR[Main]: generateImagePart(): baseime == NUL for part_of_name="[colorize:#FB0:255", cancelling. ERROR[Main]: generateImage(): Failed to generate "[colorize:#FB09:255" ERROR[Main]: part of texture "^[colorize:#FB0:255" ERROR[Main]: generateImage(): baseimg is NULL (attempted to create texture "^[colorize:#FB0:255")
Treer
force-pushed
the
feature/fix-particle-errors
branch
from
685761b to
3e6f2e5
Compare
nice, |
|
LGTM. Will merge in a few days unless there are objections. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately
[fillis only available in v5.8 clients onwards, so if anybody has a better idea? Should we break out a 1x1.png ?See issue #81